Closed jasonliu-- closed 4 years ago
Hi! We'll consider renaming the commands in the next release, but these are actually only example applications for developers, and I don't think these are essential to have in a MacPorts package. So I think it would be acceptable to simply disable the OIDN_APPS
CMake option, which will disable building these commands. This could be later turned on when we'll rename the commands. What do you think? Thanks!
We've renamed the commands to oidnTest
, oidnDenoise
, etc. It's currently available in the devel
branch.
Ok, that's great, thanks so much! I can backport this into the MacPorts package of OIDN 1.2.0 as a patch, until you release a new version of OIDN.
We've released v1.2.1
, which includes the renamed commands.
Awesome, thanks!
Hello, I'm currently working on packaging OIDN for the MacPorts package manager. In the course of creating and testing my package, I received the following error message from the MacPorts build system:
Error: Failed to activate oidn: Image error: /opt/local/bin/tests is being used by the active libde265 port. Please deactivate this port first, or use 'port -f activate oidn' to force the activation.
Of course, what this means is that OIDN's
tests
command conflicts with an identically-named command created by @strukturag's libde265 library. Is there any possibility of changing the name of thetests
command to be something less generic? I think maybe something likeoidn-tests
would make sense?