Provide a toggle to build as a static library?

RenderKit / oidn

Intel® Open Image Denoise library

https://www.openimagedenoise.org/

Apache License 2.0

1.77k stars 164 forks source link

Provide a toggle to build as a static library? #7

Closed TomCrypto closed 5 years ago

TomCrypto commented 5 years ago

Would it be possible to include an option to build the library as a static library? Just switching the SHARED to STATIC basically works (at least on Ubuntu 18.04) though there are a couple errors to fix in the install module.

atafra commented 5 years ago

Yes, we're planning to add this option soon (probably in the next release)!

ColinChargyBentley commented 5 years ago

Hi @atafra, That's perfect. Will the static build be included in release binaries for all OS? Will the mkl-dnn and tbb lib will be enclosed in the provided static lib (or will still use dynamic linkage for those) ? And finally, ETA ? :) Thanks! Regards, Colin Chargy

atafra commented 5 years ago

A CMake option (OIDN_STATIC_LIB) has been added to the devel branch and will be available in the next release. Note that you need at least CMake 3.13.0 for this option (due to a bug in earlier CMake versions).

We're not planning to include static binaries in the official release packages.