Closed david-geiger closed 4 years ago
Seems that 'list(APPEND EXTRA_SHARED_LIBS "${CMAKE_DL_LIBS}")' in mkl-dnn/src/CMakeLists.txt doesq not work as it should.
Ok this patch fixes underlinking build issue:
--- a/cmake/oidn_dnnl.cmake +++ b/cmake/oidn_dnnl.cmake @@ -52,7 +52,7 @@ if(WIN32 AND CMAKE_CXX_COMPILER_ID STREQUAL "Intel") endif() target_compile_options(dnnl_common PRIVATE ${DNNL_COMPILE_OPTIONS})
-target_link_libraries(dnnl_common PUBLIC ${CMAKE_THREAD_LIBS_INIT} ${TBB_LIBRARIES}) +target_link_libraries(dnnl_common PUBLIC ${CMAKE_THREAD_LIBS_INIT} ${CMAKE_DL_LIBS} ${TBB_LIBRARIES})
Hi! Thanks for reporting the issue and the patch! This is actually already fixed in the devel
branch in a platform-independent way. Sorry for the delayed response. The CMake files in the mkl-dnn directory are not used by OIDN.
Hi,
I tried to compile oidn 1.2.0 on Mageia linux but it fails to build due to a linking issue:
Full build log: build.0.20200601084908.log
Regards, David