RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.74k stars 160 forks source link

Even with git-lfs, weights remain links #82

Closed mboisson closed 3 years ago

mboisson commented 3 years ago

I have git-lfs installed, but even then, the weights do not download correctly :

[mboisson@build-node tmp]$ git --version
git version 2.26.2
[mboisson@build-node tmp]$ git-lfs --version
git-lfs/2.6.1 (GitHub; linux amd64; go 1.13.10)
[mboisson@build-node tmp]$ git lfs --version
git-lfs/2.6.1 (GitHub; linux amd64; go 1.13.10)
[mboisson@build-node tmp]$ git clone --recursive git@github.com:OpenImageDenoise/oidn.git
Cloning into 'oidn'...
remote: Enumerating objects: 1877, done.
remote: Counting objects: 100% (1877/1877), done.
remote: Compressing objects: 100% (740/740), done.
remote: Total 4575 (delta 1350), reused 1602 (delta 1133), pack-reused 2698
Receiving objects: 100% (4575/4575), 9.43 MiB | 14.37 MiB/s, done.
Resolving deltas: 100% (3265/3265), done.
Submodule 'mkl-dnn' (git@github.com:OpenImageDenoise/mkl-dnn.git) registered for path 'mkl-dnn'
Submodule 'weights' (git@github.com:OpenImageDenoise/oidn-weights.git) registered for path 'weights'
Cloning into '/home/mboisson/tmp/oidn/mkl-dnn'...
remote: Enumerating objects: 25373, done.
remote: Counting objects: 100% (25373/25373), done.
remote: Compressing objects: 100% (5899/5899), done.
remote: Total 47845 (delta 20486), reused 24061 (delta 19381), pack-reused 22472
Receiving objects: 100% (47845/47845), 20.50 MiB | 21.66 MiB/s, done.
Resolving deltas: 100% (38348/38348), done.
Cloning into '/home/mboisson/tmp/oidn/weights'...
remote: Enumerating objects: 27, done.
remote: Counting objects: 100% (27/27), done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 86 (delta 5), reused 25 (delta 5), pack-reused 59
Receiving objects: 100% (86/86), 135.72 MiB | 27.31 MiB/s, done.
Resolving deltas: 100% (8/8), done.
Submodule path 'mkl-dnn': checked out '9730e5bf70fb6f6dc81d8514202dbbd00adaa305'
Submodule path 'weights': checked out '08092e46a1961b13b70e48ad80fa19b452bd4c01'
[mboisson@build-node tmp]$ ls -lh oidn/weights/
total 44K
-rw-rw-r-- 1 mboisson mboisson 12K Jul 22 21:10 LICENSE.txt
-rw-rw-r-- 1 mboisson mboisson 384 Jul 22 21:10 README.md
-rw-rw-r-- 1 mboisson mboisson 132 Jul 22 21:10 rt_hdr.tza
-rw-rw-r-- 1 mboisson mboisson 132 Jul 22 21:10 rt_hdr_alb.tza
-rw-rw-r-- 1 mboisson mboisson 132 Jul 22 21:10 rt_hdr_alb_nrm.tza
-rw-rw-r-- 1 mboisson mboisson 132 Jul 22 21:10 rt_ldr.tza
-rw-rw-r-- 1 mboisson mboisson 132 Jul 22 21:10 rt_ldr_alb.tza
-rw-rw-r-- 1 mboisson mboisson 132 Jul 22 21:10 rt_ldr_alb_nrm.tza
-rw-rw-r-- 1 mboisson mboisson 132 Jul 22 21:10 rtlightmap_hdr.tza
[mboisson@build-node tmp]$ cat oidn/weights/rt_hdr.tza
version https://git-lfs.github.com/spec/v1
oid sha256:7f761c7b6f64886e60b434a8f3c6e770d5f6bfaf44be8111394d938cccda5972
size 5660823

This yields the following error when building :

Error: The file "/tmp/mboisson/avx2/OpenImageDenoise/1.2.2/GCC-9.3.0/oidn/weights/rt_ldr.tza" is a Git LFS pointer. Please install Git LFS and clone the repository again.
Error: The file "/tmp/mboisson/avx2/OpenImageDenoise/1.2.2/GCC-9.3.0/oidn/weights/rt_ldr_alb.tza" is a Git LFS pointer. Please install Git LFS and clone the repository again.
Error: The file "/tmp/mboisson/avx2/OpenImageDenoise/1.2.2/GCC-9.3.0/oidn/weights/rt_hdr_alb.tza" is a Git LFS pointer. Please install Git LFS and clone the repository again.
Error: The file "/tmp/mboisson/avx2/OpenImageDenoise/1.2.2/GCC-9.3.0/oidn/weights/rt_hdr_alb_nrm.tza" is a Git LFS pointer. Please install Git LFS and clone the repository again.
Error: The file "/tmp/mboisson/avx2/OpenImageDenoise/1.2.2/GCC-9.3.0/oidn/weights/rt_ldr_alb_nrm.tza" is a Git LFS pointer. Please install Git LFS and clone the repository again.
Error: The file "/tmp/mboisson/avx2/OpenImageDenoise/1.2.2/GCC-9.3.0/oidn/weights/rt_hdr.tza" is a Git LFS pointer. Please install Git LFS and clone the repository again.
Error: The file "/tmp/mboisson/avx2/OpenImageDenoise/1.2.2/GCC-9.3.0/oidn/weights/rtlightmap_hdr.tza" is a Git LFS pointer. Please install Git LFS and clone the repository again.
mboisson commented 3 years ago

It seems like I was missing git lfs install to create the configuration section in my .gitconfig