RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.74k stars 160 forks source link

Installs shared library files with mismatching version numbers #87

Closed yurivict closed 3 years ago

yurivict commented 3 years ago

The version oidn-1.2.3 installs these files:

lib/libOpenImageDenoise.so
lib/libOpenImageDenoise.so.0
lib/libOpenImageDenoise.so.1.2.3

0 should match the first digit in 1.2.3, otherwise some tools from toolchains might get confused.

atafra commented 3 years ago

The reason why the SOVERSION is still is 0 is that the 0.x.x API is still forward compatible with 1.x.x. Could you give a concrete example for a toolchain issue? Thanks!

atafra commented 3 years ago

Fixed in v1.3.0.