search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.74k stars 160 forks source link

HDR denoising question #91

Closed ColinChargyBentley closed 3 years ago

ColinChargyBentley commented 3 years ago

Hi @atafra or anyone else, Quick question : does denoising HDR images with OIDN involves tone-mapping, then denoising LDR images then un-tone-mapping ? If so, what's the advantage of using OIDN tone-mapping if the host application has its own tonemapping fct ? I imagine speed may be one answer.

Best regards, Colin Chargy

atafra commented 3 years ago

Hi Colin,

Denoising HDR images does indeed involve some kind of forward and inverse tone mapping internally but this is not equivalent to regular tone mapping. This is only an internal implementation detail and is not exposed to the user. Thus it's not a replacement for tone mapping performed by the application.

There is no significant speed difference between LDR and HDR denoising. If the application tone maps the image and discards the original HDR data, the image should be first tone mapped by the application and then denoised in LDR. This will ensure optimal image quality. Otherwise, the image should be denoised in HDR.

Best regards, Attila

ColinChargyBentley commented 3 years ago

Hi @atafra, Thanks a lot for these infos, that is helpful. Regards, Colin Chargy