search

RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
1k stars 182 forks source link

added include for static embree library #292

Closed pnav closed 2 months ago

pnav commented 5 years ago

Hello,

This pull request adds a small section to ospray_macros.cmake to properly include Embree as a static library if it is built statically. This relies on Embree pull request 227.

This has been verified using OSPRay 1.7.x build.

jeffamstutz commented 5 years ago

I promise this is still on our plate to merge....we've been doing more overhauls to our CMake stuff, including having our libraries respect BUILD_SHARED_LIBS more appropriately. I'll make sure this makes it into v2.0....we haven't been doing anything with v1.8.x for a while now, but it's time we get this incorporated so it doesn't get lost!

mathstuf commented 5 years ago

Why does this need to be predicated on whether embree is static or not? Is just using the embree imported target not good enough?

pnav commented 5 years ago

@mathstuf the ospray cmake at the time of this pull request hardcoded libembree.so even when embree was built statically. I understand that the cmake config for ospray has changed considerably in 1.8.x so it might work properly now. My embree static lib fixes have been merged into the embree tree for a while, so the latest there will properly expose the static library for testing with ospray.

johguenther commented 2 months ago

This is not needed any longer: OSPRay and Embree moved to modern CMake with targets.