search

RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
1k stars 182 forks source link

samplingRate does not affect isosurfaces #342

Closed StasJ closed 4 years ago

StasJ commented 5 years ago

Unstructured Volume

uns

Structured Volume

str

Notice the jagged edged and misses caused by low sampling rate. Sometimes whole chunks will be missing. "samplingRate" has no effect.

timrowley commented 5 years ago

Hi. Sorry for the delay getting back to you. Volume rendering is undergoing large changes in OSPRay 2. I'm working on the unstructured volumes and we are working on sampling improvements for these. From the issues you've been filing it appears you have some interesting unstructured datasets. Would it be possible to share any of them with us for internal testing? Thanks!

paulmelis commented 5 years ago

Is the v2 API with respect to volumes currently in flux as well? For example, parameters gradientShadingEnabled, singleShade and adaptiveSampling all seem to be missing from the code, preIntegration is now a parameter on the transfer function instead of the volume, etc.

StasJ commented 5 years ago

@timrowley I have some unstructured datasets I can gladly share with you, however I cannot post them publicly. Please let me know where I should contact you by email.

jeffamstutz commented 4 years ago

All sampling rate concerns are now a renderer parameter and intentionally do not affect isosurfaces, as isosurface intersection is now entirely Open VKL's job. We have made improvements with VKL's isosurfacing code, so testing again on OSPRay v2.0 should show improvements.

Pinging @gregjohnson here for reference.