RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
997 stars 182 forks source link

Curves tangent buffer format #391

Closed burlen closed 4 years ago

burlen commented 4 years ago

OSPRay throws an exception when "Curves" geometry supplies a tangent buffer not in vec3f format. However, Embree requires this buffer in vec4f format.

390 fixes this issue by making OSPRay check for vec4f.

from the Embree docs:

Similarly, the tangent buffer stores the derivative of each control vertex (x, y, z, r order and RTC_FORMAT_FLOAT4 format)

https://www.embree.org/api.html#rtc_geometry_type_curve

johguenther commented 4 years ago

Fixed in release-2.0.x.