search

RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
997 stars 182 forks source link

Use correct include path, should fix #415 #417

Closed paulmelis closed 1 month ago

johguenther commented 4 years ago

Unfortunately this is not robust enough as is breaks the "normal" build. Looking for alternatives.

paulmelis commented 4 years ago

Strange that the build fails, as I rebuilt locally after the change to check. But maybe that's because I rebuilt as part of the superbuild

johguenther commented 4 years ago

I found the superbuild tricky to test changes: even with ALWAYS_REBUILD=ON a rebuild is not triggered reliably. The only way to be really sure is to nuke the whole build folder.

paulmelis commented 4 years ago

Right, I indeed clean it out when needed with extra time used for that. I guess I could install ccache as some sort of a workaround, as I feel the non-superbuild is a bit tricky to do in keeping all dependencies correct in terms of versions.

johguenther commented 1 month ago

I think the proper fix is for the app is to link against target ospray::ospray_testing, see https://github.com/RenderKit/ospray/issues/415#issuecomment-2239177246.