RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
997 stars 182 forks source link

OSPRay 2.x ospSetParam(), ospSetXxxx() don't emit error output or callback for unknown param ID strings #427

Closed tachyon-john closed 4 years ago

tachyon-john commented 4 years ago

The OSPRay 2.x documentation in the Objects section describes the details of how ospSetParam() works in the Parameters paragraph. The docs say: "... unknown parameters will simply be ignored (though a warning message will be posted). "

In my testing, neither OSPRay itself, nor my registered error message callback yield any output when I pass clearly bogus parameter ID strings, e.g.: ospSetFloat(ospRenderer, "completelybogus", 37.0); int bogosity = 42; ospSetParam(ospRenderer, "alsobogus", OSP_INT, &bogosity); ospCommit(ospRenderer);

I noticed this simply because I continue to find places in my OSPRay 2.x renderer implementation where I still had an out-of-date parameter string leftover from OSPRay 1.x.

Best, John

paulmelis commented 4 years ago

@tachyon-john I guess this could be the same underlying issue with logLevel as in #428 causing lack of error reporting?

tachyon-john commented 4 years ago

Yes, it seemed so in my testing last night.

johguenther commented 4 years ago

OK, closing this as duplicate and re-purpose #428 to fix documentation of loglevel.