RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
985 stars 180 forks source link

For certain volumes the default sampling rate is unusably high #447

Closed StasJ closed 3 years ago

StasJ commented 4 years ago

For certain volumes the automatically determined sampling rate is unusable. For example, one volume spans the following volume:

and then this volume is scaled in the Z axis by about 100x using the xfm parameter. The default sampling rate results in a 60x20 pixel rendering taking about 3 minutes. Setting volumeSamplingRate to anything over 1/500 does not give improved image quality and a 1080p image renders in 2-3 seconds.

I suspect the issue is that the automatically determined sampling rate does not take into account the volume's scaling factor.

johguenther commented 3 years ago

What I found so far:

StasJ commented 3 years ago

The issue is with unstructured volumes. I have considered your suggested workaround and this is what was done when we used OSPRay 1.8 which did not support transforming volumes but it greatly complicates the implementation.

johguenther commented 3 years ago

Ok, the fix is available in Open VKL devel.

clyne commented 3 years ago

Thanks for the quick response @johguenther ! We will get right on it. We're on track to release by the end of the year and OSPRay support is a big milestone for us.

cc @StasJ

clyne commented 3 years ago

This definitely fixes the problem. Thanks! @johguenther any thoughts on when the next supported release of OSPRay will available (2.5.0?)? Thanks!

johguenther commented 3 years ago

We have a slight slip of schedule, thus it won't be now, but v2.5 will be released in January.