search

RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
1.01k stars 182 forks source link

AMR tests not exercised #452

Closed timsandstrom closed 4 years ago

timsandstrom commented 4 years ago

[which is an awesome capability to have, thanks!]

none of the tests exercise the AMR capability, and I know this because

ospray/apps/common/ospray_testing/builders/GravitySpheresVolume.cpp

has a small typo [which I found by setting asAMR=true]

volume.setParam("block.cellWidth", cpp::CopiedData(cellWidths));

which should probably be [or similar]:

volume.setParam("cellWidth", cpp::CopiedData(cellWidths));

johguenther commented 4 years ago

wow, thanks for reporting – an oversight when we changed the volume parameter name