search

RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
1.01k stars 182 forks source link

GCC11 compilation error due to missing header "limits" in benchmark_register.h #485

Closed benradel closed 3 years ago

benradel commented 3 years ago

Compilation error due to missing header "limits" in benchmark_register.h

Compiling ospray (Version 2.5, 2.6 and master) with gcc 11.1.0 leads to compilation error:

ospray/apps/common/external/benchmark/src/benchmark_register.h:22:30: error: 'numeric_limits' is not a member of 'std' 22 | static const T kmax = std::numeric_limits::max();

This fix adds the required header to benchmark_register.h #484

johguenther commented 3 years ago

Thanks for the report and PR! We are working on moving to a newer version of Google Bench, which fixed this issues with the <limits> header. I think this is more robust compared to patching our old copy.

johguenther commented 3 years ago

fixed in v2.7.0 via f82253b8201e7fd1c5885c4f6a8ec5a5ca473d57