search

RenderKit / ospray

An Open, Scalable, Portable, Ray Tracing Based Rendering Engine for High-Fidelity Visualization
http://ospray.org
Apache License 2.0
982 stars 178 forks source link

Superbuild library directories are not consistent #556

Closed mathstuf closed 12 months ago

mathstuf commented 1 year ago

When using the superbuild on a Red Hat-derived platform, some of the projects end up in <prefix>/lib (embree and tbb at least) while others show up in the right place (tbb (again?), openvkl, etc.). Telling projects to agree on a single ${CMAKE_INSTALL_LIBDIR} should be preferred.

demarle commented 1 year ago

From: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9911 Thanks, looking...

johguenther commented 1 year ago

Hmm, all the superbuild dependencies get CMAKE_INSTALL_LIBDIR forwarded, but you explicitly need to set CMAKE_INSTALL_LIBDIR when configuring the supertbuild itself (which we do in the build scripts), otherwise that variable gets "randomly" set by the projects.

mathstuf commented 1 year ago

I tried setting it at the top level and it doesn't seem to have helped :/ . I'll need to debug what is happening in the build command a bit better later.

demarle commented 1 year ago

The setting only applied to depenecies that ospray's superbuild is told to build. For those that ospray's superbuild grabs binaries for, it the dependency's tarball is simply expanded.

mathstuf commented 12 months ago

Ah, that makes sense.