RenderKit / rkcommon

Intel RenderKit common C++/CMake infrastructure
Apache License 2.0
17 stars 10 forks source link

Use of non-standard preprocessor syntax #6

Closed stukowski closed 2 years ago

stukowski commented 2 years ago

This is not a serious issue, I think, but let me report it anyway:

This kind of preprocessor expression

https://github.com/ospray/rkcommon/blob/8d76e418568a928401e35049a4e17019970df23a/rkcommon/math/rkmath.h#L37

results in a compiler warning (I am using MSVC 19.29.30037):

rkmath.h(37): warning C4067: unexpected tokens following preprocessor directive - expected a newline

Operator && should be used instead of and. Furthermore, !defined(...) should be used instead of not defined(...) (this applies to several locations in the code).