search

ReneR97 / domestika-downloader

Download full domestika courses
https://www.buymeacoffee.com/ReneR97
49 stars 14 forks source link

Can't download bundled course #19

Closed nak21 closed 2 months ago

nak21 commented 7 months ago

Close #19

ReneR97 commented 5 months ago

Hello, sorry for the late answer, but i just pushed an update that adds a check that should take care of your problem, so the tool doesnt crash when there is no final project

TSboy89 commented 5 months ago

Hi there, First of all, I really appreciate your work, it is awesome.

Unfortunately I've ran into the same reading 'relationship' error code, bundled course final video issue with the updated code. I've tried to use it with this bundled course. Note the spaces. https://www.domestika.org/ en/courses/4840-ableton-live-and-push-for-beginners/course

Should I modify the index.js according to the course's titles? The last title in the last course is U5: Practice. Ive tried to insert this text to 81, 82 line, but no difference. Could you please look into it? Thank you!

Iulipartenie commented 2 months ago

When I try to download a bundle I get this: C:\Domestika-Course-Video-Downloader-main>npm start

domestika-downloader@1.0.0 start node index.js

C:\Domestika-Course-Video-Downloader-main\index.js:72 let final_project_id = regex_final.exec($(units[units.length - 1]).attr('href'))[1]; ^

TypeError: Cannot read properties of null (reading '1') at scrapeSite (C:\Domestika-Course-Video-Downloader-main\index.js:72:85) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v18.17.1