search

ReneR97 / domestika-downloader

Download full domestika courses
https://www.buymeacoffee.com/ReneR97
49 stars 14 forks source link

Not an issue but a fix - Missing videos (not downloaded) within a Unit #23

Closed fram1963 closed 4 months ago

fram1963 commented 4 months ago

Downloading works but sometimes there are videos within a Unit not being downloaded. I found the problem. If you go in the course page on Domestika and pick a unit, you will see 1 or more videos for that unit. For some reason, some video title have a blank space at the end of the name (use inspect to see the code).

To fix the download problem related to the trailing blank space, I modified the index.js code to remove the trailing blank:

vData.title becomes vData.title.trimEnd() for both the video and subtitle:

let log = await exec(N_m3u8DL-RE -sv res="1080*":codec=hvc1:for=best "${vData.playbackURL}" --save-dir "domestika_courses/${title}/${unit.title}" --save-name "${a}_${vData.title.trimEnd()}"); let log2 = await exec(N_m3u8DL-RE --auto-subtitle-fix --sub-format SRT --select-subtitle lang="${subtitle_lang}":for=all "${vData.playbackURL}" --save-dir "domestika_courses/${title}/${unit.title}" --save-name "${a}_${vData.title.trimEnd()}");

Works like a charm now.

Cheers

ReneR97 commented 4 months ago

Hey, thanks for the Fix If you want, you can create a pull request and i will merge it. If you dont want to, just let me know and i will just put it in myself :)

fram1963 commented 4 months ago

Hi. You're welcome. You can go ahead with creating the pull request. Cheers.

On Thu, Feb 1, 2024, 11:57 AM Rene Reiterer @.***> wrote:

Hey, thanks for the Fix If you want, you can create a pull request and i will merge it. If you dont want to, just let me know and i will just put it in myself :)

— Reply to this email directly, view it on GitHub https://github.com/ReneR97/domestika-downloader/issues/23#issuecomment-1921778449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP5GBSMFRJ66UEKBTBLCI4LYRPCORAVCNFSM6AAAAABCTUXWD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRG43TQNBUHE . You are receiving this because you authored the thread.Message ID: @.***>

ReneR97 commented 4 months ago

Added the fix. Thanks again

fram1963 commented 4 months ago

Any time! Glad to help.

On Sun, Feb 11, 2024, 6:14 AM Rene Reiterer @.***> wrote:

Added the fix. Thanks again

— Reply to this email directly, view it on GitHub https://github.com/ReneR97/domestika-downloader/issues/23#issuecomment-1937588562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP5GBSP7WH5ZVVTAGUMOFSDYTCRZ3AVCNFSM6AAAAABCTUXWD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGU4DQNJWGI . You are receiving this because you authored the thread.Message ID: @.***>