search

ReneR97 / skillshare-downloader

https://www.buymeacoffee.com/ReneR97
28 stars 4 forks source link

subtitles #2

Closed steeltape closed 1 year ago

steeltape commented 1 year ago

hi, is it possible to download subtitles too?

ReneR97 commented 1 year ago

It looks like it might be possible, but not 100% sure how easy. WIll need some time to look into it

steeltape commented 1 year ago

Nice.. it would be a great help for me 😀

On Sat, Apr 15, 2023, 4:31 AM Rene Reiterer @.***> wrote:

It looks like it might be possible, but not 100% sure how easy. WIll need some time to look into it

— Reply to this email directly, view it on GitHub https://github.com/ReneR97/skillshare-downloader/issues/2#issuecomment-1509219961, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNA3YYNHXRZVXGNC2NGWFTXBGX3JANCNFSM6AAAAAAW5C3QP4 . You are receiving this because you authored the thread.Message ID: @.***>

jbthecoder5 commented 1 year ago

hi, is it possible to download subtitles too?

I recently downloaded a Shopify theme course using this and subtitles worked with the video. 2 other views I noticed didn't come with subtitles. Not sure why.

ReneR97 commented 1 year ago

Okey, i think i got it working nicely. You can just download the latest version, add your preferred subtitles language to the script and it should download the subtitles file together with the video.

Dont forget to do another "npm i" since i had to add a new module to bypass the cloudflare security on skillshare.

let me know if everything worked when you tried it.

steeltape commented 1 year ago

bro it works now. thankssssss

steeltape commented 1 year ago

hi, on my 2nd course video i tried to download it gave me this error

C:\Users\006>npm run start

skillshare-scraper@1.0.0 start node index.js

Download 1/11 Completed! file:///C:/Users/006/index.js:43 subtitles_data['text_tracks'].forEach((el) => { ^

TypeError: Cannot read properties of undefined (reading 'forEach') at file:///C:/Users/006/index.js:43:51 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

ReneR97 commented 1 year ago

can you send mie the course and the subtitles language you choose so i can test on my end?

steeltape commented 1 year ago

https://www.skillshare.com/en/classes/How-to-Draw-the-Face-at-Various-Angles-Anime-and-Manga/1491112248/lessons

https://www.skillshare.com/en/classes/How-to-Draw-the-Human-Figure-Anime-and-Manga/1495074009?via=member-home-RecommendedClassesSection

On Mon, Apr 24, 2023, 9:08 PM Rene Reiterer @.***> wrote:

can you send mie the course so i can test on my end?

— Reply to this email directly, view it on GitHub https://github.com/ReneR97/skillshare-downloader/issues/2#issuecomment-1520130568, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNA3Y6TV3YCH6VJLYUFTY3XCZ3OHANCNFSM6AAAAAAW5C3QP4 . You are receiving this because you authored the thread.Message ID: @.***>

ReneR97 commented 1 year ago

Thanks for the info. Made an Update to the tool, worked with both your courses so should be golden now. Just download the latest version

steeltape commented 1 year ago

Yes it's golden now. Thanks 👍

On Mon, Apr 24, 2023, 11:59 PM Rene Reiterer @.***> wrote:

Thanks for the info. Made an Update to the tool, worked with both your courses so should be golden now. Just download the latest version

— Reply to this email directly, view it on GitHub https://github.com/ReneR97/skillshare-downloader/issues/2#issuecomment-1520440204, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNA3Y2KASIWSZIWFXDNYVDXC2POJANCNFSM6AAAAAAW5C3QP4 . You are receiving this because you authored the thread.Message ID: @.***>