ReneReid / Internify

3 stars 0 forks source link

[IN-89] Redirect Create page to View page when creating JobPosting on last step #66

Closed tommytwm closed 3 years ago

tommytwm commented 3 years ago

User Story

[IN-89] Redirect Create page to View page when creating JobPosting on last step

Changes made

Does your new code introduce new warnings on dev console?

It shouldn't have. It was fine on my machine but I'm getting inconsistent results from a variety of scenarios. Double check on your machine.

Test Steps

  1. Login
  2. Create a job posting
  3. Once you've reached the Review step, click 'Create' to add the job posting
  4. You should be redirected to the respective View page with URI /view/:jobId
  5. Click on the back button on the top left of the View page and you should be redirected to the Profile page
  6. You should see the newly updated list of jobs in the table on the right of the Profile page
ReneReid commented 3 years ago

Hey @tommytwm - great work here! love the functionality! Just a couple things - in reference to the test steps 5, 6 above, when I go back from the newly created job to my profile page, i actually do not see a list of the created jobs. However, I do see all the jobs if I logout and login again. That might be something more related to the profile page than the job creation stages though.

The second thing is an error message - which I only saw once and have not yet been able to reproduce - when at the last step of creating a job i.e. hitting the "Create" button. The error message "TypeError: Cannot read property 'uid' of null" came up. I've attempted to recreate conditions to see how consistent this error message is, but without success so far. I guess its something we'll have to be aware of while testing.

(The following issue occurs in other branches as well) With regards to the review page, I think there is either an additional bullet point or there is a field missing in the content (please see attached picture for ease of reference).

Again, many thanks for this, Tommy!

Screen Shot 2021-07-26 at 12 51 19 PM

tommytwm commented 3 years ago

@aleemer

Since both Review Page and View Page involve copying some stuff that is displayed (JobPosting vs ViewPosting, the following errors exist for both of them).

1. each child in a list should be have the unique key prop (looks like an li issue, may need to add a key variable to the li and it should be fixed)

2. I notice that on technical requirements, the highest degree is shown as a requirement in review (should be the minimal)

3. I just notice a 404 Not Found on the Put request in console (may have been there previously)

Otherwise, no issues that I can find.

(1) This error pops up when and if the user copy pastes any of the information from prior fields in the Create section to any of the continuing fields. For testing purposes, this can be ignored for now. However, it is assumed that users will not be copying and pasting the same content on any of the fields in Create Fixed (2) I'm not sure I understand this. Could you clarify? Fixed (3) I'm not able to replicate this. Would you be able to provide steps?

ReneReid commented 3 years ago

@JudeShamsi @tommytwm - this is great!! thank you for getting it up and running! I've played around with the create/view pages and everything is as expected for those functions. I can create a job post, go back and see it included in my Profile page, view it, go back to my profile page etc.
The next story im working on - Editing a job post - will very likely be building on this. Excited!