[IN-107] Feat/in107 create selection page

goofyangel commented 3 years ago

User Story

https://chaosneutral.atlassian.net/jira/software/projects/IN/boards/1?selectedIssue=IN-107
Rene and I both worked on this together.

Changes made

On selection page, can click preview prefills, which takes you to a new Template page
On this page, users can see the prefills (technical requirements specifically) templates
Adding templateObjects, these will be passed into Create to pre-populate the jobData object with the templates (also includes a blankStudent which is what is used when you create a new posting)
onClick feature added to each template div, can support extendable functionality (behaviour on click)
Back button takes you back to selection page (preview prefills/make new posting)

Does your new code introduce new warnings on dev console?

No

Test Steps

Go to localhost:3000/templates, click on each, look inside console.

tommytwm commented 3 years ago

Remove this grey line (it's supposed to be the scroll bar)

tommytwm commented 3 years ago

Remove the max height on this container so that users are able to scroll vertically without the view being fixed height

goofyangel commented 3 years ago

Double check your class names, there's a conflict that's causing the navbar padding to shrink and now there's awkward spacing:

I think this is an issue on develop. I'm encountering the same thing on my branch (merged develop into it), and it doesn't contain the templates. We'll see what we can do about fixing it in this PR though.

tommytwm commented 3 years ago

Double check your class names, there's a conflict that's causing the navbar padding to shrink and now there's awkward spacing:

I think this is an issue on develop. I'm encountering the same thing on my branch (merged develop into it), and it doesn't contain the templates. We'll see what we can do about fixing it in this PR though.

Seems like this is a one-off thing. I've tried replicating this again by restarting the app locally on both develop and this branch, and I wasn't able to replicate it. We can discard this if we're not seeing this again

tommytwm commented 3 years ago

I'm not getting the slightly dark grey document on hover. Is this implemented?

goofyangel commented 3 years ago

I'm not getting the slightly dark grey document on hover. Is this implemented?

So unfortunately, I don't think this can be added without doing a lot more work. Because of the scrollbar, when you set the background to dark grey on a hover, it only sets the part of the div that is in the scrollbar's view to grey, the rest is white even when you scroll down.

ReneReid / Internify