search

ReneVolution / profanity-omemo-plugin

A Python plugin to use (axolotl / Signal Protocol) encryption for the profanity XMPP messenger
GNU General Public License v3.0
64 stars 14 forks source link

Plugin error - prof_omemo_plugin.prof_on_message_stanza_send(): return value undefined, expected string, unicode or None #25

Closed devurandom closed 7 years ago

devurandom commented 7 years ago

When I type /omemo start for an OMEMO enabled contact and then try to write a message to them, I see this in the Profanity main window: Plugin error - prof_omemo_plugin.prof_on_message_stanza_send(): return value undefined, expected string, unicode or None.

During the whole time, the session is shown as unencrypted in Profanity, and all messages are transmitted unencrypted.

Profanity version is 0.5.1, plugin version is 0.1.1.

Updating to 8e2b0e394431258fdfd034c22af4625d97b6b2f7 solves the issue. Should a new release be cut?

ReneVolution commented 7 years ago

Just to confirm ... are you using the plugin from master? What is an "OMEMO enabled contact"? Is that someone who has announced it's device id and bundle?

devurandom commented 7 years ago

I edited the description, adding the required information, probably after you received the email you replied to:

Profanity version is 0.5.1, plugin version is 0.1.1. Updating to 8e2b0e3 solves the issue. Should a new release be cut?

Just to confirm ... are you using the plugin from master?

What is an "OMEMO enabled contact"? Is that someone who has announced it's device id and bundle?

That is someone who I am already exchanging OMEMO encrypted messages with, by means of Conversations.

ReneVolution commented 7 years ago

Ok. So, I close this ticket then. A new version will be released soon.

devurandom commented 7 years ago

Do you have an ETA for the release?

ReneVolution commented 7 years ago

There is still a couple of issues i would like to fix first. End of July seems feasible, maybe earlier, no promises.

licaon-kter commented 7 years ago

Building from master, still seeing this on Termux/profanity 0.5.1.

licaon-kter commented 7 years ago

So this was fixed?

Still seeing it (git HEAD/termux):

(ME is on Profanity, CONTACT is on Conversations)

ReneVolution commented 7 years ago

@licaon-kter The issue is different. For some - yet unknown - reason, it fails for you to create your own bundle announcement message. It is an serialisation issue, which is weird as it works perfectly on other machines. I wonder if this is some string/bytes issue with Python 3.6.

licaon-kter commented 7 years ago

Maybe it's a Termux (and associated ARM packages) thing?

ReneVolution commented 7 years ago

Yes. Possible. Can't test that though.