RenegadeLucien / project-tenacity

Project Tenacity, the final evolution of the "Level 3 to X" guides
47 stars 6 forks source link

Automatically complete requirements of quests that have been loaded from RuneMetrics #63

Open Mr-Lasagne opened 4 years ago

Mr-Lasagne commented 4 years ago

Hey, me again. I picked up a few issues over the past few weeks so thought I'd compile them into one post. Firstly, there are some duplicate achievements. In each case the former exists in game and the latter does not:

  1. Another Slice of H.A.M. exists but Another Slice of H.A.M (no period on the end) is listed too
  2. There's a duplicate of As a First Resort spelled As A First Resort...
  3. A Fairy Tale I - Growing Pains has a duplicate spelled Fairy Tale I - Growing Pains
  4. A duplicate of the two other Fairy Tale quests exist too, both spelled the same except without an 'A'
  5. Watchtower is listed as well as The Watchtower
  6. Fur 'n Seek is listed as well Fur 'n' Seek
  7. Flag Fall (miniquest) is listed along with Flag Fall (minquest)
  8. Evil Dave's Big Day Out is listed as well as Evil Dave's big day out
  9. The Prisoner of Glouphrie is listed as well as Prisoner of Glouphrie Okay now some possibly incorrect information I came across:
  10. Arc - Mitts and Waders - Tetsu requires 90 smithing in-game but isn't listed as doing so in the app
  11. Seeing Lava says it takes 0.559333 hours to complete but the wiki says one run of Fight Caves takes between 30 mins and 2.5 hours. Seeing Lava requires that you do the Fight Cave twice Lastly some small suggestions:
  12. Benedict's World Tour, part 1 and Benedict's World Tour, part 2 should tick off if Benedict's World Tour (Miniquest) is completed
  13. Invention Tutorial should tick off if any Invention achievements are done
  14. I was interested in knowing whether any possibility of failure was included in the combat calculations, not sure how this would be implemented just looking to see what you think about the idea Forgive me for the long post. Is this the best way to bring up this types of issues? Should I bring them up as soon as I encounter them or wait until I have a few like I did here?
RenegadeLucien commented 4 years ago

Alright, so for 1-9) I'm going to assume you are loading Project Tenacity from an account that has all of these quests/miniquests completed. The reason for these is that the quest's name in Project Tenacity does not match the name in RuneMetrics, so they aren't being loaded from your profile as they should be. Some of these (like 7, which is likely a typo) were probably wrong since release, but others (like 8, which I distinctly remember being lowercased like that) were probably changed in RuneMetrics by Jagex. I don't know which is which, but all of them should be fixed.

For 10) are you sure about this? Actually making the Tetsu boots and gloves requires 90 smithing, but according to RSWiki you only need to purchase the scroll to complete this achievement, and you can do this without 90 smithing.

For 11) there are a few possible explanations for this: -If you have already completed the Fight Caves, and your Project Tenacity profile has a Jad KC of greater than zero, Project Tenacity will recognize that you only need to complete the Fight Caves one more time (admittedly this does assume you still have your fire cape) so it will only count the time for one run-through. If your stats and gear are strong, the combat simulator might calculate that one run-through of the Fight Caves would take about 0.55 hours (33 minutes.) -If this is just the number displayed on the main screen, and not on the extended details pop-up for the achievement, the total time cost for the achievement might be factoring in the time saved from the XP gained during the Fight Caves, and thus deducting it from the time spent on the caves (which would be longer.) Let me know if either of these seem accurate.

For 12) if you tick off the miniquest achievement directly, it will automatically tick off the sub-achievements. However, if the miniquest is ticked off via loading from RuneMetrics, it won't tick off the sub-achievements. I'll see if I can find a way around this.

For 13) Invention achievements which do not have an Invention level requirement should tick off the Invention tutorial when completed, because for those I explicitly declared that the tutorial was a requirement. However, I did not do this on achievements with Invention level requirements, as for these completing the tutorial is only implicitly required. Since completing the Invention tutorial is required to gain any XP in Invention, even via bonus XP rewards, I will add an explicit requirement on the tutorial for all achievements with Invention requirements.

As for 14), the combat calculator first uses your current stats and gear to calculate how long a combat encounter will take, and if it decides you can't win with your current stats, it will continue using incrementally upgraded stats and gear until it finds where you can win, then reports these stats and gear as requirements on the task. But once it decided it's found a point where you can win, it will assume that you can, indeed, win. So regarding whether possibility of failure is accounted for, the answer is, yes and no.

In the future, it would probably be better if you brought each type of issue as a separate issue. In this case, 1-9, 10, 11, 12-13, and 14 could have been brought up as five separate issues, instead of one.

Most of these fixes are done, but I won't be able to release a new version for a while, since the release of Archaeology threw a bunch of stuff out of whack (which relied on there being exactly 27 skills) and I'll need to have at least some methods of training the skill ready before a new version comes out. Hopefully I'll be able to release it next week, but no guarantees.

Mr-Lasagne commented 4 years ago

Thanks for leaving such a detailed response. You're absolutely right about 10), I apologise. For 11) your first suggestion seems to fit best. I hadn't completed the fight cave before but after checking my qualities tab I noticed the kill count for Jad was 1, must be a mistake on my part.

Ok, I'll be sure to separate the issues properly if I encounter anything else. I completely understand that it will take some time to be released, thanks again for responding so quickly.

All the best.

RenegadeLucien commented 4 years ago

Everything here should be fixed in v1.0.10 except 12 (auto-completing requirements of quests loaded as complete from RuneMetrics.)

Gonna downgrade this to T60 (feature request) and work on it after updating with Archaeology and other updates I have missed over the past several months.