Implement Error for CircuitError

Renmusxd / RustQIP

Quantum computing using rust. Efficient and a borrow-checked no cloning theorem!

https://docs.rs/qip/

MIT License

223 stars 18 forks source link

Implement Error for CircuitError #48

Closed sunsided closed 10 months ago

sunsided commented 10 months ago

This PR does three things:

It changes the package resolver to version 2, unblocking restores on current cargo versions.
It implements Display and Error for CircuitError, allowing it to be used like a regular error.
It changes CircuitError from a struct to an enum, making it more extensible.

Renmusxd commented 10 months ago

Thanks for the PR! I'll look over the code and merge it in the next day or two!

sunsided commented 10 months ago

One thing to mention is that matching on Self:: variants only works on Rust 1.37 and later. You don't have a minimum supported Rust version on it. Seems reasonable to me but I can also change that to use CircuitError:: explicitly.

Renmusxd commented 10 months ago

It was my understanding that "edition=2021" also specified a minimum supported rust version, although followup reading seems to just claim its invalid to specific incompatible edition+msrv pairs.

sunsided commented 10 months ago

Thanks for the merge and thanks for the project. 🙂