search

Renovamen / oh-my-cv

An in-browser, local-first Markdown resume builder.
https://ohmycv.app
GNU General Public License v3.0
216 stars 39 forks source link

feature: allow image in CV header (via URL) #7

Open catabozan opened 5 months ago

catabozan commented 5 months ago

I have added a new property called image that can be set via the MarkDown attributes.

You can set the image to any URL and it will be displayed on the left side of the header text.

If no image is present or if it's not a valid url, it will not be displayed and the layout stays the same as the current one.

Renovamen commented 2 months ago

Hi @catabozan, thank you for your pull request!

Adding an image is a great feature. However, before we move forward, I think we need to consider how to adjust the resume header styles when adding an image. Right now, the styles don't center the header or align it to a side, which could be improved. I don't have a clear idea yet on how to style headers with images, so I'll need some time to think about it and possibly refine this pull request before approving it.

Do you have any thoughts on this? Thanks again!