Renovus-Tech / solarec-java

GNU Affero General Public License v3.0
0 stars 1 forks source link

Inverters - Connect to Solarman #62

Open pferrariuy opened 2 months ago

pferrariuy commented 2 months ago

API Documentation

URLs

Endpoints

Required information from client / location / generator

Data and data convertion

Weather information is not availabe and must be retrieve from the WeatherService.

Pendings

RomeoIndiaJulietUniform commented 1 month ago

Hii @pferrariuy, during building the packages for the microservices a part of the tech.renovus.solarec.business.impl.SecurityService is causing problem as the function is not created before. I have commented it as of now , should I create a function for that incomplaince with buisness logic ??

Screenshot from 2024-09-29 17-39-22

and while converting those DataTypeVo.TYPE_SOLAR_INVERTER_AC_POWER to Watts by dividing by 1000 we will be dealing with Doubles not Integeres so I have also converted the DC power to Double as it will be in complaince while calculations , for which I have changed the interface too.

Screenshot from 2024-09-29 17-38-22

Is there anything I am missing or should I raise a PR after all these changes ?

pferrariuy commented 1 month ago

Hi @RomeoIndiaJulietUniform nice seeing new faces arround. Thanks for the information.

Currently we are working to implement the service to connect to Solarman API. Do you have any experience in that that could help?

Regarding the issue found at tech.renovus.solarec.business.impl.SecurityServiceImpl, no need to create a new function. Looks like you have an issue in the one of the following places:

Regarding the division by 1000 that will generate Double and not Integer, we are currently working to fix SonarCloud issues. All security and realibility issues are fixed and working hard to fix maintainability (first high, then medium and then low).

Also notice that you have a value of .502, but in reallity must be 502 in the DataTypeVo class. Those are just constant numbers used for IDs.

Looking closer, looks like you an old version of the proyect and some manual editions have been made, since can't find thoses editions in the blame section of the files.

Fill free to contact is more information is needed.

Regards