Renovus-Tech / solarec-python

GNU Affero General Public License v3.0
0 stars 0 forks source link

Date difference makes alert not visible for the next 24 hours #12

Open pferrariuy opened 3 months ago

pferrariuy commented 3 months ago

Type of Issue:

Description:

When doing a processing (2024-04-05 07:00) of data retrieved at 2024-04-05 02:00 of the date 2024-05-04, the alert is generated with date 2024-05-05 07:00. When accessing the Home / Overview page, the combobox on the right has value yesterday, and the alert is not displayed; which means the user will have to wait 24 more hours to see the alert.

Expected Behavior:

That the alerts generated will procesing the information of yesterday can be seend during the current day.

Should the alert added date be the one of the processing? The date before? The date of the max data used?

Current Behavior:

Alert is not being shown.

Steps to Reproduce (for Bugs):

  1. Wait for automatic inverter processing
  2. Wait for automatic data calculation
  3. Acces Home / Overview page

Checklist:

Reviewers:

ignacioes77 commented 3 months ago

Please see comments below:

Should the alert added date be the one of the processing? The alert should correspond to the day prior to the current date. For example, if today is April 14, 2024, the alert should correspond to anomalies detected for data corresponding to the previous day, April 13, 2024. So that errors that occured the day before, can be detected and proper steps to correct issues can be taken. The date before? See above The date of the max data used? See above

pferrariuy commented 2 months ago

The comment has been taken in consideration during development of: https://github.com/Renovus-Tech/solarec-java/issues/37