search

RensAlthuis / vertical-overview

Gnome has had vertically stacked workspaces for a long time. The Gnome 40 update unfortunately made the switch to a horizontal layout. A choice that many Gnome users disagree with. This extension completely replaces the new Gnome overview with something that resembles the old style.
GNU General Public License v3.0
311 stars 30 forks source link

Transition/animation lags & related JS ERRORs in log #114

Closed M4rtinK closed 2 years ago

M4rtinK commented 2 years ago

After upgrading to Fedora 36 with Gnome Shell 42.3.1 I have noticed that after some time the system is running the shell starts to lag significantly when a transition should be taking place - such as when using the hot corner or super/windows key.

Transition to the overview seems fine, but clicking on window thumbnail results in a multi-second lag and even when the maximized window is visible it takes some time before it can be interacted with.

Checking Journal when this happens, its spammed with a vertical-overview related message, dozens of times every time the lag happens.

srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21
srp 01 17:56:46 localhost.localdomain gnome-shell[3392]: JS ERROR: TypeError: bgManager.backgroundActor is null
                                                         set_backgrounds/bgManager._fadeSignal<@/home/mkolman/.local/share/gnome-shell/extensions/vertical-overview@RensAlthuis.github.com/workspace.js:42:21

This can be "fixed" by rebooting and fresh login - then it does not happen initially and all works fine for a while. But eventually it always starts happening after a while - I think it might be related to connecting/disconnecting of external monitors (I use the laptops built in screen + 2 monitors connected via a thunderbolt docking station).

I tried to connect/disconnect the thunderbolt docking station on a freshly booted system, but was not able to reproduce the lag & error messages, so something else seems to be in play as well.

I even installed the latest extension version here from Github but it did not help. In any case, this was not happening before on F35 with Gnome Shell 41.x.

Let me know if I can provide any more useful information and help debugging the issue in any way - your extension is a real life-saver on modern Gnome Shell! :)

intelfx commented 2 years ago

Same issue here, makes the extension basically unusable (and by extension makes me interested in working on a fix). I'm unfamiliar with JS and/or GNOME Shell development, thus if someone could provide any pointers for investigation I'd be grateful.

RensAlthuis commented 2 years ago

I just now pushed a new version to the extensions website. I think it might solve this issue.

intelfx commented 2 years ago

No, it does not help. I've been using a local build at 8c25abdfd3949234f62845d4d6ccdf5af24788f1 for some time anyway.

I have fixed the error spam in my branch here at https://github.com/intelfx/vertical-overview/commit/1e6ae15b860c0ba30a7c4350d34178f3b2a2209d, but I'm not yet exactly sure if it is related to the animation lag problem.

intelfx commented 2 years ago

Update — sadly, no, the actual issue is still there.

Maybe this PR (https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2450) is also needed, if the original issue actually was related to connectObject/disconnectObject.