search

ReolinkCameraAPI / reolinkapipy

Reolink Camera API written in Python 3.6
GNU General Public License v3.0
207 stars 46 forks source link

Reolink api v7 #65

Open Vaelatern opened 1 year ago

Vaelatern commented 1 year ago

I'll be slowly working on this as I need it. https://www.reddit.com/r/reolinkcam/comments/xpcxq6/reolink_camera_api_user_guide_v7_update_in_sept/

Please consider merging, or telling me what to improve so my work can be merged.

Have a great day!

Vaelatern commented 1 year ago

I think I did conversions to int() because of a bug I ran into.

I forget.

I'm happy to make those changes though.

It's worth noting this doesn't support all of v7, just the parts I needed.

If you think that's fine, I'm willing to apply the requested changes and see what happens.

Benehiko commented 1 year ago

I think I did conversions to int() because of a bug I ran into.

I forget.

I'm happy to make those changes though.

It's worth noting this doesn't support all of v7, just the parts I needed.

If you think that's fine, I'm willing to apply the requested changes and see what happens.

Yes, could you verify that there is indeed an error if you do not convert to int?

Also please update the PR title using conventional commits as it is good practice and be more specific than api v7. To me this is more of a cleanup of some of the function parameter types and also you fix the modify user function to accept the old password. Here is an example: fix: cleanup function parameter types to conform to api v7 specs

https://www.conventionalcommits.org/en/v1.0.0/#summary

Vaelatern commented 1 year ago

I'm still going to update this

Please note the PR title is disconnected from the commits, which are correctly named. The PR title you can edit to describe as you like.