RepairShopr / react-native-signature-capture

A simple modular component for react native (iOS) to capture a signature as an image
MIT License
962 stars 514 forks source link

Compatibility with React Native v0.60 #180

Open dineshmm23 opened 5 years ago

dineshmm23 commented 5 years ago

[!] use_native_modules! skipped the react-native dependency 'react-native-signature-capture'. No podspec file was found.

Os: IOS React Native :0.60

vinhtnk commented 5 years ago

Temporary, you can use my fork with podspec, declare in package.json: "react-native-signature-capture": "git+https://github.com/vinhtnk/react-native-signature-capture.git",

FrenchMajesty commented 5 years ago

There are also issues that gradle throws up due to the fact that this package uses compile in its node_modules/react-native-signature-capture/android/build.grade which has been replaced by implementation.

This is the console output:

Configure project :react-native-signature-capture WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

salvariable commented 5 years ago

Using RN 0.60.5, I added the podspec to my project through Xcode, then added it to Build Phases and IT WORKED! This should not be the solution though since the pod is already being installed with autolink...

sumit1317 commented 5 years ago

Using RN 0.60.5, I added the podspec to my project through Xcode, then added it to Build Phases and IT WORKED! This should not be the solution though since the pod is already being installed with autolink...

Can you help me with this .. I am really stuck ..

salvariable commented 5 years ago

Please make sure you're using this library from master, since the latest release doesn't include the podspec file YET:

  1. In the XCode's "Project navigator", right click on your project's Libraries folder ➜ Add Files to <...>

  2. Go to node_modules ➜ react-native-signature-capture ➜ select react-native-signature-capture.podspec

  3. Add libreact-native-signature-capture.a to Build Phases -> Link Binary With Libraries

sumit1317 commented 5 years ago

I am installing like this "npm install react-native-signature-capture --save" .... but this file is not there

salvariable commented 5 years ago

Please make sure you're using this library from master... this means: your react-native-signature-capture must be pointing to "git://github.com/RepairShopr/react-native-signature-capture" instead of a version number.

sumit1317 commented 5 years ago

Performed install like this "npm install --save git+https://github.com/RepairShopr/react-native-signature-capture" , able to add react-native-signature-capture.podspec, but Unable to find libreact-native-signature-capture.a, when setting via XCODE.

salvariable commented 5 years ago

Check your Pods/Projects folder in the Xcode file tree...

sumit1317 commented 5 years ago

There is no Projects folder. It is not in "Pods/Products"

salvariable commented 5 years ago

Sorry, I meant Pods/Products.

When you performed pod install after installing react-native-signature-capture, did you confirm the library pod WAS installed? If not, please do. libreact-native-signature-capture.a will appear there.

sumit1317 commented 5 years ago

Awesome ..done for iOS. What steps to follow for Android ? Are they same as mentioned on https://github.com/RepairShopr/react-native-signature-capture or different ?

salvariable commented 5 years ago

I would say they're the same as mentioned, haven't had any trouble with it.

sumit1317 commented 5 years ago

I have a form wherein I need two signatures separately, and it seems this has an issue with it, because the moment I had 2nd SignatureCapture component in my form, with seperate functions to be called on SAVE and RESET clicks, the first one stops working, as _onSaveEvent does not get called. Do you have any workaround for this ?

salvariable commented 5 years ago

@sumit1317 Question seems irrelevant for this issue, please open a new one or check SO

sumit1317 commented 5 years ago

For Android :- With new react-native-signature-capture pointing to "git:// github.com/RepairShopr/react-native-signature-capture" , and instructions mentioned on https://github.com/RepairShopr/react-native-signature-capture to set it up for Android, I am not able to work it out on Android.

Are there new instructions which I need to follow for Android ?

Regards, Sumit S Chadha

On Thu, Aug 22, 2019 at 12:23 AM Salvador notifications@github.com wrote:

@sumit1317 https://github.com/sumit1317 Question seems irrelevant for this issue, please open a new one or check SO

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RepairShopr/react-native-signature-capture/issues/180?email_source=notifications&email_token=ABUGXWRUB26JJRVBDNMTMCDQFVFU5A5CNFSM4H7OKCZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Z2V2Y#issuecomment-523479787, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUGXWWR2FJNILAUPUJ4EOTQFVFU5ANCNFSM4H7OKCZQ .

salvariable commented 5 years ago

A question on compatibility... does anyone happen to know if this lib is hooks-ready?

mthomas-github commented 4 years ago

Simulator Screen Shot - iPhone 11 - 2020-04-20 at 14 03 36

still seem issue when using the above fork

anantshukla commented 4 years ago

@mthomas-github Were you able to resolve it? I'm stuck here.

vinhtnk commented 4 years ago

Simulator Screen Shot - iPhone 11 - 2020-04-20 at 14 03 36

still seem issue when using the above fork Did you run pod install and rebuild ios app?

anantshukla commented 4 years ago

@vinhtnk The issue is with the package itself. Tried manually linking it and whatnot. I suggest you go ahead with some other library. Check this out: "https://github.com/YanYuanFE/react-native-signature-canvas" Works flawlessly and is updated pretty often.