search

RepairShopr / react-native-signature-capture

A simple modular component for react native (iOS) to capture a signature as an image
MIT License
961 stars 512 forks source link

It will be good thing to give this repo to the react native comunity #187

Open kneza23 opened 5 years ago

kneza23 commented 5 years ago

  1. As with new RN version 0.60+ the library is unusable (AndroidX).

  2. Lots of requests regarding features are coming in the issues of the repo so people are making their own forks for stuff like:

All of those requests could be easily implemented in props, and library could be maintained by the community. We need more customisable library with lots more options to suit needs of much broader scale of people as this is the only one native library for signatures.

TimothyOsborn commented 5 years ago

Seconded

kaammii commented 5 years ago

Agreed

joaopiopedreira commented 4 years ago

Agree!

abhilekhsingh041992 commented 4 years ago

Agreed

darsodango commented 4 years ago

Agreed!

ErickMaeda commented 4 years ago

Agreed!

msvargas commented 4 years ago

Agreed

joaopiopedreira commented 4 years ago

Agreed

luckyxhu commented 4 years ago

Agreed

RigoOnRails commented 3 years ago

@eriktrom pretty please?

eriktrom commented 3 years ago

Totally agree with the sentiment in the thread, so I fixed it... but I no longer a) have contributor rights b) need to know who to ask to move this permanently to reactjs org c) so i published a fork in the meantime.

Anyone is free to ping me and I'll transfer it to reactjs org or to you personally, either way works, as long as it gets there.

PS - I have no control of this repo as of yesterday. Send all pr's to the fork, but ideally, let's get that fork official ASAP.

Thanks all, great that we all work together. (getting mushy, oh boy).

ping me if you have question, oh, and someone answer who I should talk to and where (besides just landing a random ticket, this seems like a better convo on Discord, if possible, prior to submitting in an async manner... I presume).

celebrate the image

image

Links:

Here is the fork:

https://github.com/eriktrom/react-native-signature-capture.git

and the npm public published repo

https://www.npmjs.com/package/@eriktrom/react-native-signature-capture

again, anyone is free to throw this over the fence now, just ping me if help is needed and/or when I can take down my friendly fork.

STATUS: This issue is open for discussion, closed, otherwise.

I knowingly lost green button access by helping the community in this issue. LOL

eriktrom commented 3 years ago

finalize:

@theinventor - i or whomever makes the final transfer of the repo to react org will need to mirror the repo - it does not need to continue as a mirror, but we we removed my collab rights today, i lost issues and pr's on the repo that was setup to do that. It changed around 4:30pm, according the security log.

thanks if we can switch it back, but actually mirror to FB instead of me this time...

theinventor commented 3 years ago

Hey everyone - I'm an admin at RepairShopr(org) and thanks Erik for escalating this!

(Erik, I removed some comments that are probably just better for private convo between you and I, happy to talk offline)

@jedt (from our team) is the author of this library, and is happy to continue maintaining it. We kind of had a pretty tight philosophy about what was allowed to get merged before but we've talked and agreed to do a little more since this project is used by more people than we had realized!

Old way; We only merged/worked on bugfixes mainly, or things we needed.

New way: We plan to be more receptive to merging things if they follow some basic guidelines for contribution.

We'll work on some guidelines right away, maybe give ourselves a deadline of end of next week to have some stuff published.

We'll keep up on issues and triage them more quickly.

We'll try to merge things quick - mainly if your PR includes a good description, supports both iOS & Android, and hopefully is backward compatible when possible. more to come!

If the community wants to run with a fork that's totally cool too, we aren't here to tell folks how to use their open source. You can take this one Erik forked or make a new one/whatever works.

We are happy to keep this repo public and keep investing resources in keeping it rolling, triaging issues, supporting new platforms as they come out, publishing on NPM, etc.

ALSO - If any of the folks following here would like to assist in maintaining I'd love to chat, reply here and we can DM somewhere and figure out what works.

@jedt is happy to work on bug fixes that people report, merge PRs that are well built, and we'll put more eyes from the team on watching this repo going forward.