Repooc / ReforgedArmory

Armory module that adds a bit more customization to the character and inspect frames.
7 stars 2 forks source link

Cataclysm Update? #37

Open Astraar opened 4 months ago

Astraar commented 4 months ago

Hi, Im asking myself if there will be an update for cata. The basic UI is really not great. Have to open the character info every time is really annoying. Even just the basics would be ok. Bigger frame, background control and the option to always open the info panel would be enough.

Repooc commented 4 months ago

yes i have started on something locally but due to some limitations with lack of api, some things are being a pita lol no eta just yet but yeah the info panel open when u open character sheet is what i would want to have in it as well

Astraar commented 4 months ago

Thanks for the reply. Im glad your working on it. Yea take yout time, i can only imagine how fun it is to do something in this mess of an patch. Thanks for your work!

Repooc commented 3 months ago

ElvUI_CataArmory-Alpha.zip A quick conversion, just make sure to uncheck the options in elvui for Display Inspect Info and Display Character Info like shown image

newjelly78 commented 3 months ago

Whenever character information is displayed (short key C), a message is output regarding a specific item.

[Shadow Silk Spindle] no string true [wrathful gladiators silk trousers] no string true [wrathful gladiators grimoire] no string true

plz help me!

Astraar commented 3 months ago

Yea getting the same. No LUA error tho.

PzgI7R7

Repooc commented 3 months ago

That is bc I was an idiot and left print statement in

Astraar commented 3 months ago

Besides the chat spam, everything seems to work but the character windows is still the same. (size/background/character stats) Is this this supposed to happen? Or is this on my end Enchants/gems/warning work

Repooc commented 3 months ago

ElvUI_CataArmory.zip another packaged zip for you all to test out

Repooc commented 3 months ago

Whenever character information is displayed (short key C), a message is output regarding a specific item.

[Shadow Silk Spindle] no string true [wrathful gladiators silk trousers] no string true [wrathful gladiators grimoire] no string true

plz help me!

sounds like u are using an old version, do not "hijack" other tickets as I did not see your response until now. make a new ticket with your issue... considering I don't have the cata really available, there is nothing you can report at this time... you can test out the rewrite that I linked above.

Astraar commented 3 months ago

I tried the newest from github directly. besides the missing enchant stuff, it works for the most part. still missing some stuff (like arrange stats and bigger window size) but overall good.

one error i found was when you change tabs (reputation / currency) the autoexpand does not work unless you close and open the character window again

Repooc commented 3 months ago

y. besid

no plan to rearrange the stats at this time, that is the blizzard stats and dont see a real need to move them at this time and still have a lot to work on, what missing enchant stuff?

ill look into the expand thing, can u make sure to make new sep tickets for each issue so i can knock them out 1 by 1

Repooc commented 3 months ago

in response the bigger window thing, think the only window i "may" increase the width of is the inspect frame, as I only have so much room before i would have to play with how wow anchors the windows when onshow and such which i rather not do

just added some more missing enchant ids from ticket #38 if you have more missing that u come across, make sure to provide the enchantid it says is missing and screenshot of the gear with the enchant text showing should be able to mouse over the item in the msg to show that info like this (this was a test as i removed enchant id for it) image

Astraar commented 3 months ago

ill do it if i come across missing id's (latest update fixed the enchants i had)

the wrath version had a way bigger window because the enchant text and gem icons getting into the character screen. at some point you will not be able to see the 3d character anymore. they changed how this works in cata so its more "risky" to modify?

if its too much work then its ok. what there is already helps a lot.

(for the character stats order etc.) as a caster you always get the useless stats at the top. but its not a big deal, there is already an addon that remembers the order, and it works with CataArmory.

thanks for the work so far

Repooc commented 3 months ago

the wrath version had a way bigger window because the enchant text and gem icons getting into the character screen. at some point you will not be able to see the 3d character anymore. they changed how this works in cata so its more "risky" to modify?

mainly its the inspect frame, the character frame in wrath is a bit different, yes and had more room to play with but may be possible still. I will have to toy with it still to see how much i feel comfortable with. Considering the upcoming option to search/replace enchant text to display a way for users they rather see than what is shown, due to locale or just to damn long of a string lol

(for the character stats order etc.) as a caster you always get the useless stats at the top. but its not a big deal, there is already an addon that remembers the order, and it works with CataArmory.

Which addon is this, maybe i will add something similar, depending on the work needed to deal with it.

Astraar commented 3 months ago

Which addon is this, maybe i will add something similar, depending on the work needed to deal with it.

https://www.curseforge.com/wow/addons/characterstatspane-improved

dl0802 commented 3 months ago

Not sure if should post here or open a new issue but getting error/prompt to document it here: Spell id 4190 (145 stam + 55 agi, self leatherworking emboss) not showing up on legs Spell id 4439 (130 agi, self leatherworking emboss) not showing up on bracers

edit: rings show red because they are "missing an enchant" but not everyone can enchant rings due to enchanting. should check if character has enchanting (if possible) and show red if they do have it, and show nothing if they dont have it.

Repooc commented 3 months ago

new issue for each issue u have assuming the same exact issue isnt already a ticket

ring issue has been reported at #39

for you other issue(s), make a new ticket for it to help keep track. I assume you get a message about missing "enchant id", not spell id like you suggested? If my assumption is correct and you receive a message in chat with an item link you can mouse over, can you take a screenshot of the message and when you mouse over the item which should display a tooltip? (for each missing enchant id msg you get)

Edit: Looking at the 2 "spell id" (i am thinking you mean enchant id), I am missing both of those, once you get back on the clarification on whether you meant enchant id from the chat message or not, I will add those in for you

dl0802 commented 3 months ago

Yeah sorry, I meant enchant ids. I opened a new ticket for them

Repooc commented 3 months ago

Yeah sorry, I meant enchant ids. I opened a new ticket for them

sweet thanks for the info, ill get them added in a few mins

telias82 commented 3 months ago

I have these disabled but it still shows up odd image image

telias82 commented 3 months ago

also, not seeing the plugin in /ec image

Repooc commented 3 months ago

I have these disabled but it still shows up odd image image

Create Your own ticket with the info, do not hijack someone else's ticket with your issue, you did no say how you downloaded the addon... DO NOT try to download directly from github, it will NOT work for you. You should get it from wago addons or curseforge.