search

RepreZen / KaiZen-OpenApi-Parser

High-performance Parser, Validator, and Java Object Model for OpenAPI 3.x
130 stars 31 forks source link

[#180] Add position information to validation items #181

Closed ghillairet closed 6 years ago

ghillairet commented 6 years ago

@andylowry I noted that some positions are missing when doing URL validations because overlays are not passed over during error creation. This PR includes changes to pass overlays for URL validation (Maybe other validations are also not passing overlays). Please feel free to look at it and merge if my changes are correct.

andylowry commented 6 years ago

@ghillairet Yeah, as stated earlier, the ONLY error that's got line numbers worked into it at present is the Schema.type invalid value error. One example seemed (barely) enough for you to integrate the editor and at least see something. With the availability of the Overlay class, validation can be much simpler, and I've been working on ValidatorBase changes (along with others) to make this the case. I'm about ready to start recasting all the validations for all the model classes in the new framework, which mostly means dropping out most of the method parameters from most validation calls.

andylowry commented 6 years ago

@ghillairet There should no longer be any validation items without position info in the current builds. You can use the latest update site at http:;//products-internal.reprezen.com/kaizen/openapi-parser/updates to use this version. (Sorry I was leaving you with bare jar files... realized in discussion with @tfesenko that you need an update site for KZOE, and so I've revived it).

If thiings are working correctly, I'll close this PR without merging.

andylowry commented 6 years ago

@ghillairet I'm pretty sure we're in good shape wrt position info in all validation messages now, so I'll close this PR.