Representable / representable

We’re creating maps of communities to fight for fair representation. Add your community to the map today and make your voice heard.
https://representable.org
GNU General Public License v3.0
15 stars 6 forks source link

Custom drive #788

Closed aceaton closed 3 years ago

aceaton commented 3 years ago

currently there are some css issues (with which help would be appreciated) but other than that i think it should work??

aceaton commented 3 years ago

oh also translating thing isn't there yet bc its being bad

aceaton commented 3 years ago

To review first of all this is where we discussed all the changes: https://www.notion.so/princeton/Org-Customizability-6da6c85d6c394c58b1e07609447d81d8

makemigrations, migrate, runserver make orgs

let me know if any of the functionality works weirdly or anything looks ugly

k-y-le commented 3 years ago

some small notes:

  1. the alignment of this checkbox is slightly off (weirdly, on the third time creating a drive, it was no longer off, not sure what's going on there, but probably something we can change later) image
  2. this is more a design thing (@okusio ) but i feel that this example text could be a bit more verbose to encourage descriptive descriptions image
  3. I'd like to see slightly more padding between the title of the form fields and the fields themselves -- also, should the field be "Mapping Units" or "Default Mapping Units" ? image
  4. I think the slogan text ("Gerrymandering is silencing communities") on the drive landing page should be moved down a bit more image
  5. not a big deal but worth noting that the form fields when editing a drive don't have consistent appearance with the form fields when creating a drive image
  6. uploading images with different dimensions can cause a bit of ugly formatting on the drive page (i don't think this is an immediate concern) image image
  7. this aspect of editing an organization's details isn't super clear what's going on w.r.t. changing the drive logo image

these are all minor tho, the actual functionality works great for me! so going to approve