RF/BF: rely on "hash singularity" command instead of OSTYPE check to decide to use singularity

ReproNim / containers

Containers "distribution" for reproducible neuroimaging

Apache License 2.0

26 stars 14 forks source link

RF/BF: rely on "hash singularity" command instead of OSTYPE check to decide to use singularity #41

Closed yarikoptic closed 4 years ago

yarikoptic commented 4 years ago

This should allow to use singularity on OSX where there is some build/shimming installation provided by singularity itself (Should close #33 if works). Unfortunately for me currently tests fail locally: https://github.com/ReproNim/containers/issues/40 . Let's see if they still pass on travis

yarikoptic commented 4 years ago

unfortunately tests are no longer in a good state. #42 is WiP toward fixing them up. This one should not cause failures like that, so merging

yarikoptic commented 4 years ago

actually I am taking my words back -- mixed up with #40 ... the failure on OSX:

1..5
FAIL: Arguments are not equal.
 #1=<<scripts/singularity_cmd: line 100: hash: singularity: not found>>
 #2=<<arg #1=<foo bar>>>
not ok 1 verifying arguments passed to singularity_cmd Docker shim

will push a fix