ReproNim / containers

Containers "distribution" for reproducible neuroimaging
Apache License 2.0
26 stars 16 forks source link

Translate `create_singularities` to Python #75

Closed jwodder closed 2 years ago

jwodder commented 2 years ago

Closes #73.

jwodder commented 2 years ago

@yarikoptic Please test this; I don't have singularity. (Also, the test failures are completely unrelated to this PR.)

yarikoptic commented 2 years ago

ok, will review and test asap. Thanks! I forgot to warn you that there is a somewhat broken state of datalad in 20.04 which leads to testing failing here ATM IIRC, and tests are indeed unrelated to this script IIRC (they should test our singularity shim which allows to run singularity on OSX etc).

yarikoptic commented 2 years ago

oops, I ran the workflow while in this branch - that is why all those commits appearing here! but as could be seen -- it did the right thing also for another

-   image = images/bids/bids-mindboggle--0.0.4.sing
+ image = images/bids/bids-mindboggle--0.0.4-1.sing

as such - I announce this PR complete for its original purpose and will merge /push locally. Thank you @jwodder !