Closed kaczmarj closed 1 year ago
Base: 83.74% // Head: 83.74% // No change to project coverage :thumbsup:
Coverage data is based on head (
f79ef3e
) compared to base (218697a
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Prior to this PR, the
--version
output from containers would includedirty
, indicating uncommitted changes. This was because/docs
was not copied into the docker images.Before this commit, the version output looks like this:
And after this commit, the version is:
Note the lack of
.dirty
in the output.By excluding
/docs
from the Docker images, we were modifying the state of the git repository, andgit status
was reporting uncommitted changes. This caused the commandneurodocker --version
to show that there were uncommitted changes (by including thedirty
suffix in the version). We do not want users to be under the impression that the version includes uncommitted changes. Indeed, kaczmarj excluded/docs
from the docker builds as a premature optimization... it turns out that they only consume 136 kb, which is negligible.