search

ReproNim / neurodocker

Generate custom Docker and Singularity images, and minimize existing containers
https://www.repronim.org/neurodocker/
Apache License 2.0
326 stars 97 forks source link

[MAINT] Simplify type annotations #551

Closed Remi-Gau closed 1 year ago

Remi-Gau commented 1 year ago
Remi-Gau commented 1 year ago

built on top of #549 so will have to be merged after it

Remi-Gau commented 1 year ago

built on top of #549 so will have to be merged after it

once this #549 I will clean up the diff to make reviewing easier

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.80% and project coverage change: -0.16% :warning:

Comparison is base (e184ed6) 88.79% compared to head (a3a6125) 88.63%. Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #551 +/- ## ========================================== - Coverage 88.79% 88.63% -0.16% ========================================== Files 11 11 Lines 1035 1021 -14 ========================================== - Hits 919 905 -14 Misses 116 116 ``` | [Files Changed](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim) | Coverage Δ | | |---|---|---| | [neurodocker/cli/minify/\_prune.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvY2xpL21pbmlmeS9fcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | | | [neurodocker/\_\_init\_\_.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [neurodocker/cli/cli.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvY2xpL2NsaS5weQ==) | `89.47% <100.00%> (-0.53%)` | :arrow_down: | | [neurodocker/cli/generate.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvY2xpL2dlbmVyYXRlLnB5) | `91.59% <100.00%> (-0.15%)` | :arrow_down: | | [neurodocker/cli/minify/trace.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvY2xpL21pbmlmeS90cmFjZS5weQ==) | `84.09% <100.00%> (+0.18%)` | :arrow_up: | | [neurodocker/reproenv/\_\_init\_\_.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvcmVwcm9lbnYvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [neurodocker/reproenv/renderers.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvcmVwcm9lbnYvcmVuZGVyZXJzLnB5) | `93.06% <100.00%> (-0.14%)` | :arrow_down: | | [neurodocker/reproenv/state.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvcmVwcm9lbnYvc3RhdGUucHk=) | `97.29% <100.00%> (-0.04%)` | :arrow_down: | | [neurodocker/reproenv/template.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvcmVwcm9lbnYvdGVtcGxhdGUucHk=) | `93.51% <100.00%> (-0.12%)` | :arrow_down: | | [neurodocker/reproenv/types.py](https://app.codecov.io/gh/ReproNim/neurodocker/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReproNim#diff-bmV1cm9kb2NrZXIvcmVwcm9lbnYvdHlwZXMucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.