ReproNim / neurodocker

Generate custom Docker and Singularity images, and minimize existing containers
https://www.repronim.org/neurodocker/
Apache License 2.0
326 stars 97 forks source link

[ENH] implement more recent mrtrix version #579

Closed Remi-Gau closed 11 months ago

Remi-Gau commented 11 months ago

image

https://github.com/ReproNim/neurodocker/actions/runs/6192140394/job/16811702090#step:6:639

 > [2/3] RUN apt-get update -qq     && apt-get install -y -q --no-install-recommends            ca-certificates            g++            gcc            git            libeigen3-dev            make            python3            python3-numpy            zlib1g-dev     && rm -rf /var/lib/apt/lists/*     && mkdir -p /opt/mrtrix3-3.0.2     && git clone https://github.com/MRtrix3/mrtrix3.git /opt/mrtrix3-3.0.2     && cd /opt/mrtrix3-3.0.2     && git checkout 3.0.2     && python3 configure -nogui     && echo "Compiling MRtrix3 ..."     && NUMBER_OF_PROCESSORS="" python3 build:
30.85 Checking for PNG library: not found - PNG support disabled
30.90 Checking for FFTW library: not found - FFTW support disabled
30.94 
30.94 writing configuration to file 'config': ok
30.94 
30.94 Compiling MRtrix3 ...
32.07 Traceback (most recent call last):
32.07   File "/opt/mrtrix3-3.0.2/build", line 1454, in <module>
32.08     num_processors = int(os.environ['NUMBER_OF_PROCESSORS'])
32.08 ValueError: invalid literal for int() with base 10: ''
codecov[bot] commented 11 months ago

Codecov Report

Patch has no changes to coverable lines.

:loudspeaker: Thoughts on this report? Let us know!.

Remi-Gau commented 11 months ago

will merge to trigger the bootstrap workflow

Remi-Gau commented 11 months ago

Note that recent versions of mrtrix work fine but that my fix attempt for the install from source did not:

https://github.com/ReproNim/neurodocker/actions/runs/6216791918/job/16871082112

Remi-Gau commented 11 months ago

Actually things could be worse

image

kaczmarj commented 11 months ago

It could be a difference in Eigen available on the different platforms. But I wouldn’t know how to fix that anyway…Best,JakubOn Sep 17, 2023, at 21:50, Remi Gau @.***> wrote: Actually things could be worse

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>