ReproNim / neurodocker

Generate custom Docker and Singularity images, and minimize existing containers
https://www.repronim.org/neurodocker/
Apache License 2.0
327 stars 97 forks source link

[MAINT] update linting config and CI #604

Closed Remi-Gau closed 6 months ago

Remi-Gau commented 6 months ago
Remi-Gau commented 6 months ago

ouch... @stebo85 the yml auto-reformat is turning this simple PR into a monster of line changes.

let me know if you want me to move this to a different PR: I still believe that given how yml centric this repo is, we should have some style check on it

Remi-Gau commented 6 months ago

or I can at least put the yml reformat in a different commit run with datalad run.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.01%. Comparing base (4d41b49) to head (0f6fc2e). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #604 +/- ## ======================================= Coverage 88.01% 88.01% ======================================= Files 11 11 Lines 1035 1035 ======================================= Hits 911 911 Misses 124 124 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaczmarj commented 6 months ago

thanks very much for adding mypy support!! looks great.

Remi-Gau commented 6 months ago

It was already there!! I think.