ReproNim / nimh-minimal

https://repronim.org/nimh-minimal/
MIT License
0 stars 4 forks source link

Update schema #5

Closed ibevers closed 1 month ago

ibevers commented 1 month ago

Updated with links to updated activities in: https://raw.githubusercontent.com/ReproNim/reproschema-library/enh/rc4/activities/

The conditional logic of what activities are shown based on age conforms to: https://nda.nih.gov/nda/nimh-common-data-elements

Demo: https://ibevers.github.io/reproschema-ui/#/?url=https://raw.githubusercontent.com/ibevers/nimh-minimal/update_schema/nimh_minimal/nimh_minimal_schema

satra commented 1 month ago

this added the .venv directory

ibevers commented 1 month ago

this added the .venv directory

Fixed @satra

satra commented 1 month ago

also can we update the github workflow checksum, so this protocol renders using the correct ui committish?

ibevers commented 1 month ago

also can we update the github workflow checksum, so this protocol renders using the correct ui committish?

Slightly confused by what you mean here. My conclusion from the conversation about the UI before is that the only way to render a protocol with a specific version of the UI is to host that version somewhere. Would you mind explaining a bit more?

satra commented 1 month ago

My conclusion from the conversation about the UI before is that the only way to render a protocol with a specific version of the UI is to host that version somewhere.

indeed and it would be hosted here in this repo. so updating the checksum in config.env should be all that's needed.

ibevers commented 1 month ago

But what should I update the checksum to? The latest checksum for the fix/static branch of reproschema-ui?

https://github.com/ReproNim/reproschema-ui/tree/fix/static

satra commented 1 month ago

i think that was already merged, so the current checksum should be fine.

satra commented 1 month ago

sorry it wasn't merged. so yes, you can take the committish of that branch and use it.

ibevers commented 1 month ago

sorry it wasn't merged. so yes, you can take the committish of that branch and use it.

Done @satra