ReproNim / reproman

ReproMan (AKA NICEMAN, AKA ReproNim TRD3)
https://reproman.readthedocs.io
Other
24 stars 14 forks source link

run: Extend --follow with optional stopping/deleting actions #479

Closed kyleam closed 4 years ago

kyleam commented 4 years ago

This is a work-in-progress series that addresses gh-470 and partially addresses gh-469.

codecov[bot] commented 4 years ago

Codecov Report

Merging #479 into master will decrease coverage by 4.71%. The diff coverage is 67.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   89.54%   84.82%   -4.72%     
==========================================
  Files         148      148              
  Lines       12132    12182      +50     
==========================================
- Hits        10863    10333     -530     
- Misses       1269     1849     +580
Impacted Files Coverage Δ
reproman/interface/tests/test_run.py 99.59% <100%> (+0.02%) :arrow_up:
reproman/interface/run.py 100% <100%> (ø) :arrow_up:
reproman/support/jobs/tests/test_orchestrators.py 31.96% <25%> (-61.43%) :arrow_down:
reproman/support/jobs/orchestrators.py 46.56% <41.17%> (-43.39%) :arrow_down:
reproman/resource/tests/test_ssh.py 27.53% <0%> (-72.47%) :arrow_down:
reproman/interface/tests/test_execute.py 71.84% <0%> (-28.16%) :arrow_down:
reproman/support/jobs/submitters.py 56.08% <0%> (-20.28%) :arrow_down:
reproman/resource/ssh.py 75% <0%> (-14.17%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e39954...004da53. Read the comment docs.

yarikoptic commented 4 years ago

looks good to me. I will merge

Noted that it seems that fetch for FetchDatalad* is reported not covered by tests. Are those just not enabled or indeed there is no test to cover possible setups with datalad orchestrators?

kyleam commented 4 years ago

Noted that it seems that fetch for FetchDatalad* is reported not covered by tests. Are those just not enabled or indeed there is no test to cover possible setups with datalad orchestrators?

I think it is the not-too-uncommon case of codecov reporting things as uncovered that are actually covered. Later today I'll double check the coverage of the fetch() methods with a local run.

kyleam commented 4 years ago

Locally I ran

coverage run -m pytest -xs -rs --integration \
  reproman/interface/tests/test_run.py \
  reproman/support/jobs/tests/test_orchestrators.p

The following lines are uncovered in FetchDataladPairMixin.fetch:

https://github.com/ReproNim/reproman/blob/942bbab693431015bbb82e5770b97c087c57108c/reproman/support/jobs/orchestrators.py#L945

https://github.com/ReproNim/reproman/blob/942bbab693431015bbb82e5770b97c087c57108c/reproman/support/jobs/orchestrators.py#L960-L961

The following line is uncovered in FetchDataladRunMixin.fetch:

https://github.com/ReproNim/reproman/blob/942bbab693431015bbb82e5770b97c087c57108c/reproman/support/jobs/orchestrators.py#L1012

Scanning through the Travis log, the datalad-based tests do seem to be getting executed (i.e. they haven't started to be skipped for some reason), so I feel fairly confident that the codecov report isn't accurate.