search

ReproNim / reproman

ReproMan (AKA NICEMAN, AKA ReproNim TRD3)
https://reproman.readthedocs.io
Other
24 stars 14 forks source link

[ERROR ] '_resolved_command_str' [jobs.py:show_oneline:102] (KeyError) #492

Closed yarikoptic closed 4 years ago

yarikoptic commented 4 years ago 
$> git describe
v0.2.1-29-gb6d1973

$> reproman -l 2 jobs
2019-12-04 15:36:50,858 [ERROR  ] '_resolved_command_str' [jobs.py:show_oneline:102] (KeyError) 
2019-12-04 15:36:50,858 [Level 5] Exiting

Ideally (besides making it more robust or puking with a dedicated error) there should also be some debug level message stating what files are read here about jobs status. I guess I have some stale (incompatible) ones laying around but need to figure out where to look.

kyleam commented 4 years ago

I guess I have some stale (incompatible) ones laying around

Yes, this is due to 8520c508a (ENH: run: Don't touch command_str spec value, 2019-09-30).

I personally don't think it is a good idea to add compatibility kludges for changes that were made while marked as beta. Adding more debug messages is of course fine.

yarikoptic commented 4 years ago

+1 for no compatibility kludges. But may be worth adding "version" information into job specs, so later on would be possible to crash with "job spec X is of incompatible prior version Y, please remove and rerun" or alike.

kyleam commented 4 years ago

But may be worth adding "version" information into job specs, so later on would be possible to crash with "job spec X is of incompatible prior version Y, please remove and rerun" or alike.

Yeah, good point. The specs do currently have a version (as of bfb5edbe6), but we could consider places where we could catch an exception and give a hint that maybe the old version spec is the cause.

kyleam commented 4 years ago

I think what is done by gh-515 should be sufficient.