search

ReproNim / reproman

ReproMan (AKA NICEMAN, AKA ReproNim TRD3)
https://reproman.readthedocs.io
Other
24 stars 14 forks source link

jobs: Treat deleted local directory as orchestrator error #497

Closed kyleam closed 4 years ago

kyleam commented 4 years ago

The first two commits are minor clean-ups around the same code path as the title issue, which is addressed by the final commit.

codecov[bot] commented 4 years ago

Codecov Report

Merging #497 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   89.64%   89.66%   +0.01%     
==========================================
  Files         148      148              
  Lines       12193    12209      +16     
==========================================
+ Hits        10931    10947      +16     
  Misses       1262     1262
Impacted Files Coverage Δ
reproman/interface/jobs.py 99% <100%> (+0.04%) :arrow_up:
reproman/interface/tests/test_run.py 99.61% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f307fba...c7fdb3b. Read the comment docs.

kyleam commented 4 years ago

The new test is leaving a process behind. I'll rework it.

kyleam commented 4 years ago

The new test is leaving a process behind. I'll rework it.

Updated.

range-diff ``` 1: f1220553d = 1: f1220553d CLN: jobs: Drop unused exception binding 2: e1f417ea8 = 2: e1f417ea8 BF: jobs: Don't dump job spec when logging orchestrators errors -: --------- > 3: b16279a61 TST: run: Add local directory to context() fixture 3: 436949871 = 4: f2b372064 BF: jobs: Treat deleted local directory as orchestrator error ```