kyleam commented 4 years ago

The download is failing due to a new redirect, causing test_conda_init_install_and_detect to fail. Update the URL, and also tweak the curl call to avoid this issue in the future.

This isn't the full rework that our conda functionality needs (gh-446), but it's a prerequisite for that and should put master back into a passing state.

codecov[bot] commented 4 years ago

Codecov Report

Merging #507 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   89.51%   89.53%   +0.01%     
==========================================
  Files         148      148              
  Lines       12209    12209              
==========================================
+ Hits        10929    10931       +2     
+ Misses       1280     1278       -2

Impacted Files	Coverage Δ
reproman/distributions/tests/test_conda.py	`100.00% <ø> (ø)`
reproman/distributions/conda.py	`94.16% <100.00%> (ø)`
reproman/interface/diff.py	`95.71% <0.00%> (+0.71%)`	:arrow_up:
reproman/config.py	`89.61% <0.00%> (+1.29%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4f026d...0bc58d9. Read the comment docs.

yarikoptic commented 4 years ago

woohoo -- thank you @kyleam !

ReproNim / reproman

Fix miniconda download #507

Codecov Report