Closed kyleam closed 4 years ago
Merging #510 into master will decrease coverage by
0.00%
. The diff coverage is75.00%
.
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 89.60% 89.60% -0.01%
==========================================
Files 148 148
Lines 12281 12290 +9
==========================================
+ Hits 11005 11013 +8
- Misses 1276 1277 +1
Impacted Files | Coverage Δ | |
---|---|---|
reproman/tests/skip.py | 97.75% <66.66%> (ø) |
|
reproman/support/external_versions.py | 86.46% <69.23%> (-0.15%) |
:arrow_down: |
reproman/cmd.py | 78.66% <100.00%> (+0.43%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e8dbb5...f84a48c. Read the comment docs.
I've updated the series to avoid a few other spots where .run()
failures were presented as errors despite being expected. If there is worry about creating conflicts with external_versions.py or cmd.py updates that could come in via the branch 3rd, I'm okay dropping all of the commits after the second.
As for the 3rd... I think they so would be manageable, and I didn't check how much we already diverged, may be we would just pick up needed fixes as we go
The point is to check whether the functionality is available, so don't pollute the test output with alarming things like
This is just a minor cosmetic thing that was bothering me as I was working on another topic.