ReproNim / reproman

ReproMan (AKA NICEMAN, AKA ReproNim TRD3)
https://reproman.readthedocs.io
Other
24 stars 14 forks source link

runscript: Improve status file checks #514

Closed kyleam closed 4 years ago

kyleam commented 4 years ago

This series has a commit from @chaselgrove and one from @yarikoptic. The first commit isn't strictly needed because the second drops the find call, but I think it is good to have that change in case we end up going back to a find call.

Based on looking at https://ss64.com/osx/grep.html, I think this grep call should be okay on macOS.

codecov[bot] commented 4 years ago

Codecov Report

Merging #514 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         148      148           
  Lines       12290    12290           
=======================================
  Hits        11013    11013           
  Misses       1277     1277           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 214dbea...0ca833b. Read the comment docs.

yarikoptic commented 4 years ago

woohoo -- thanks! looks good to me, let's proceed