kyleam commented 4 years ago

If an invalid value for the submitter or orchestrator is given, run() fails with an uninformative KeyError. Add the accepted values as constraints so that run() fails early with a helpful message.

This is an alternative to gh-517.

Suggested-by: @yarikoptic

codecov[bot] commented 4 years ago

Codecov Report

Merging #520 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         148      148           
  Lines       12302    12302           
=======================================
  Hits        11019    11019           
  Misses       1283     1283

Impacted Files	Coverage Δ
reproman/interface/run.py	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ec37d3...bc603b0. Read the comment docs.

yarikoptic commented 4 years ago

Awesome, thanks

ReproNim / reproman

ENH: run: Specify constraints for --sub and --orc #520

Codecov Report