search

ReproNim / reproman

ReproMan (AKA NICEMAN, AKA ReproNim TRD3)
https://reproman.readthedocs.io
Other
24 stars 14 forks source link

run: Don't abort if sibling unexpectedly exists but has expected target #527

Closed kyleam closed 4 years ago

kyleam commented 4 years ago

If the target directory on the remote doesn't exist, DataladOrchestrator.prepare_remote() checks whether a sibling of the same name exists and aborts if it does. In gh-440, @yarikoptic points out that this is unnecessarily strict:

I think that ideally it should not even complain/crash if remote is configured and has desired target path (I believe it is the fact here)

This series addresses that bit of gh-440.

codecov[bot] commented 4 years ago

Codecov Report

Merging #527 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   89.66%   89.68%   +0.02%     
==========================================
  Files         148      148              
  Lines       12389    12405      +16     
==========================================
+ Hits        11109    11126      +17     
+ Misses       1280     1279       -1
Impacted Files Coverage Δ
reproman/support/jobs/orchestrators.py 93.85% <100.00%> (+0.31%) :arrow_up:
reproman/support/jobs/tests/test_orchestrators.py 94.98% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57be567...24016d1. Read the comment docs.