kyleam commented 4 years ago

As explained in e381f4b69 (ENH: ssh: Log connection based on Fabric's values, 2018-11-27), the Fabric switch means that ssh_config files are now considered, and the host attribute can point to a nickname, with things like port configured via ssh_config.

Advertise this to reproman backend-parameters callers.

codecov[bot] commented 4 years ago

Codecov Report

Merging #532 into master will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         148      148           
  Lines       12431    12431           
=======================================
  Hits        11150    11150           
  Misses       1281     1281

Impacted Files	Coverage Δ
reproman/resource/ssh.py	`89.16% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13a380c...c3bdce8. Read the comment docs.

yarikoptic commented 4 years ago

Thank you for the attention to detail!

ReproNim / reproman

DOC: ssh: Mention that SSH config nickname is accepted as host #532

Codecov Report